Piteball
/
android_kernel_samsung_msm8976
mirror of https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git
1
1
Fork 0
Code Issues Projects Releases Wiki Activity
android_kernel_samsung_msm8976/net/ipv4
History
Eric Dumazet c055dec37f soreuseport: initialise timewait reuseport field 
commit 3099a52918937ab86ec47038ad80d377ba16c531 upstream.

syzbot reported an uninit-value in inet_csk_bind_conflict() [1]

It turns out we never propagated sk->sk_reuseport into timewait socket.

[1]
BUG: KMSAN: uninit-value in inet_csk_bind_conflict+0x5f9/0x990 net/ipv4/inet_connection_sock.c:151
CPU: 1 PID: 3589 Comm: syzkaller008242 Not tainted 4.16.0+ #82
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x185/0x1d0 lib/dump_stack.c:53
 kmsan_report+0x142/0x240 mm/kmsan/kmsan.c:1067
 __msan_warning_32+0x6c/0xb0 mm/kmsan/kmsan_instr.c:676
 inet_csk_bind_conflict+0x5f9/0x990 net/ipv4/inet_connection_sock.c:151
 inet_csk_get_port+0x1d28/0x1e40 net/ipv4/inet_connection_sock.c:320
 inet6_bind+0x121c/0x1820 net/ipv6/af_inet6.c:399
 SYSC_bind+0x3f2/0x4b0 net/socket.c:1474
 SyS_bind+0x54/0x80 net/socket.c:1460
 do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x3d/0xa2
RIP: 0033:0x4416e9
RSP: 002b:00007ffce6d15c88 EFLAGS: 00000217 ORIG_RAX: 0000000000000031
RAX: ffffffffffffffda RBX: 0100000000000000 RCX: 00000000004416e9
RDX: 000000000000001c RSI: 0000000020402000 RDI: 0000000000000004
RBP: 0000000000000000 R08: 00000000e6d15e08 R09: 00000000e6d15e08
R10: 0000000000000004 R11: 0000000000000217 R12: 0000000000009478
R13: 00000000006cd448 R14: 0000000000000000 R15: 0000000000000000

Uninit was stored to memory at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:278 [inline]
 kmsan_save_stack mm/kmsan/kmsan.c:293 [inline]
 kmsan_internal_chain_origin+0x12b/0x210 mm/kmsan/kmsan.c:684
 __msan_chain_origin+0x69/0xc0 mm/kmsan/kmsan_instr.c:521
 tcp_time_wait+0xf17/0xf50 net/ipv4/tcp_minisocks.c:283
 tcp_rcv_state_process+0xebe/0x6490 net/ipv4/tcp_input.c:6003
 tcp_v6_do_rcv+0x11dd/0x1d90 net/ipv6/tcp_ipv6.c:1331
 sk_backlog_rcv include/net/sock.h:908 [inline]
 __release_sock+0x2d6/0x680 net/core/sock.c:2271
 release_sock+0x97/0x2a0 net/core/sock.c:2786
 tcp_close+0x277/0x18f0 net/ipv4/tcp.c:2269
 inet_release+0x240/0x2a0 net/ipv4/af_inet.c:427
 inet6_release+0xaf/0x100 net/ipv6/af_inet6.c:435
 sock_release net/socket.c:595 [inline]
 sock_close+0xe0/0x300 net/socket.c:1149
 __fput+0x49e/0xa10 fs/file_table.c:209
 ____fput+0x37/0x40 fs/file_table.c:243
 task_work_run+0x243/0x2c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x10e1/0x38d0 kernel/exit.c:867
 do_group_exit+0x1a0/0x360 kernel/exit.c:970
 SYSC_exit_group+0x21/0x30 kernel/exit.c:981
 SyS_exit_group+0x25/0x30 kernel/exit.c:979
 do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x3d/0xa2
Uninit was stored to memory at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:278 [inline]
 kmsan_save_stack mm/kmsan/kmsan.c:293 [inline]
 kmsan_internal_chain_origin+0x12b/0x210 mm/kmsan/kmsan.c:684
 __msan_chain_origin+0x69/0xc0 mm/kmsan/kmsan_instr.c:521
 inet_twsk_alloc+0xaef/0xc00 net/ipv4/inet_timewait_sock.c:182
 tcp_time_wait+0xd9/0xf50 net/ipv4/tcp_minisocks.c:258
 tcp_rcv_state_process+0xebe/0x6490 net/ipv4/tcp_input.c:6003
 tcp_v6_do_rcv+0x11dd/0x1d90 net/ipv6/tcp_ipv6.c:1331
 sk_backlog_rcv include/net/sock.h:908 [inline]
 __release_sock+0x2d6/0x680 net/core/sock.c:2271
 release_sock+0x97/0x2a0 net/core/sock.c:2786
 tcp_close+0x277/0x18f0 net/ipv4/tcp.c:2269
 inet_release+0x240/0x2a0 net/ipv4/af_inet.c:427
 inet6_release+0xaf/0x100 net/ipv6/af_inet6.c:435
 sock_release net/socket.c:595 [inline]
 sock_close+0xe0/0x300 net/socket.c:1149
 __fput+0x49e/0xa10 fs/file_table.c:209
 ____fput+0x37/0x40 fs/file_table.c:243
 task_work_run+0x243/0x2c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x10e1/0x38d0 kernel/exit.c:867
 do_group_exit+0x1a0/0x360 kernel/exit.c:970
 SYSC_exit_group+0x21/0x30 kernel/exit.c:981
 SyS_exit_group+0x25/0x30 kernel/exit.c:979
 do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x3d/0xa2
Uninit was created at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:278 [inline]
 kmsan_internal_poison_shadow+0xb8/0x1b0 mm/kmsan/kmsan.c:188
 kmsan_kmalloc+0x94/0x100 mm/kmsan/kmsan.c:314
 kmem_cache_alloc+0xaab/0xb90 mm/slub.c:2756
 inet_twsk_alloc+0x13b/0xc00 net/ipv4/inet_timewait_sock.c:163
 tcp_time_wait+0xd9/0xf50 net/ipv4/tcp_minisocks.c:258
 tcp_rcv_state_process+0xebe/0x6490 net/ipv4/tcp_input.c:6003
 tcp_v6_do_rcv+0x11dd/0x1d90 net/ipv6/tcp_ipv6.c:1331
 sk_backlog_rcv include/net/sock.h:908 [inline]
 __release_sock+0x2d6/0x680 net/core/sock.c:2271
 release_sock+0x97/0x2a0 net/core/sock.c:2786
 tcp_close+0x277/0x18f0 net/ipv4/tcp.c:2269
 inet_release+0x240/0x2a0 net/ipv4/af_inet.c:427
 inet6_release+0xaf/0x100 net/ipv6/af_inet6.c:435
 sock_release net/socket.c:595 [inline]
 sock_close+0xe0/0x300 net/socket.c:1149
 __fput+0x49e/0xa10 fs/file_table.c:209
 ____fput+0x37/0x40 fs/file_table.c:243
 task_work_run+0x243/0x2c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x10e1/0x38d0 kernel/exit.c:867
 do_group_exit+0x1a0/0x360 kernel/exit.c:970
 SYSC_exit_group+0x21/0x30 kernel/exit.c:981
 SyS_exit_group+0x25/0x30 kernel/exit.c:979
 do_syscall_64+0x309/0x430 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x3d/0xa2

Fixes: da5e36308d ("soreuseport: TCP/IPv4 implementation")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
 		2019-07-27 21:52:18 +02:00
..
netfilter Revert "netfilter: have ip*t REJECT set the sock err when an icmp is to be sent" 2019-07-27 21:51:03 +02:00
Kconfig net: diag: Support destroying TCP sockets. 2016-05-18 14:36:07 +05:30
Makefile
…
af_inet.c ANDROID: Add untag hacks to inet_release function 2019-07-27 21:50:41 +02:00
ah4.c ipv4: properly refresh rtable entries on pmtu/redirect events 2019-07-27 21:45:24 +02:00
arp.c
…
cipso_ipv4.c netlabel: out of bound access in cipso_v4_validate() 2019-07-27 21:43:04 +02:00
datagram.c
…
devinet.c ipv4: Don't do expensive useless work during inetdev destroy. 2017-04-22 23:02:54 +02:00
esp4.c xfrm: Return error on unknown encap_type in init_state 2019-07-27 21:46:27 +02:00
fib_frontend.c net: core: add UID to flows, rules, and routes 2019-07-27 21:50:59 +02:00
fib_lookup.h
…
fib_rules.c
…
fib_semantics.c
…
fib_trie.c
…
gre.c
…
icmp.c net: inet: Support UID-based routing in IP protocols. 2019-07-27 21:50:59 +02:00
igmp.c net: igmp: add a missing rcu locking section 2019-07-27 21:49:18 +02:00
inet_connection_sock.c net: inet: Support UID-based routing in IP protocols. 2019-07-27 21:50:59 +02:00
inet_diag.c net: inet: diag: expose the socket mark to privileged processes. 2019-07-27 21:50:56 +02:00
inet_fragment.c
…
inet_hashtables.c
…
inet_lro.c
…
inet_timewait_sock.c soreuseport: initialise timewait reuseport field 2019-07-27 21:52:18 +02:00
inetpeer.c
…
ip_forward.c
…
ip_fragment.c ANDROID: Revert "net: increase fragment memory usage limits" 2019-07-27 21:51:06 +02:00
ip_gre.c
…
ip_input.c
…
ip_options.c
…
ip_output.c udp: avoid ufo handling on IP payload compression packets 2019-07-27 21:51:31 +02:00
ip_sockglue.c netfilter: drop outermost socket lock in getsockopt() 2019-07-27 21:49:20 +02:00
ip_tunnel.c ip_tunnel: better validate user provided tunnel names 2019-07-27 21:52:03 +02:00
ip_vti.c Make the VTI code compile. 2019-07-27 21:51:05 +02:00
ipcomp.c ipv4: properly refresh rtable entries on pmtu/redirect events 2019-07-27 21:45:24 +02:00
ipconfig.c
…
ipip.c
…
ipmr.c ipmr, ip6mr: fix scheduling while atomic and a deadlock with ipmr_get_route 2019-07-27 21:42:37 +02:00
netfilter.c
…
ping.c net: inet: Support UID-based routing in IP protocols. 2019-07-27 21:50:59 +02:00
proc.c
…
protocol.c
…
raw.c net: raw: do not report ICMP redirects to user space 2019-07-27 21:51:42 +02:00
route.c UPSTREAM: net: ipv4: Don't crash if passing a null sk to ip_do_redirect. 2019-07-27 21:51:00 +02:00
syncookies.c net: inet: Support UID-based routing in IP protocols. 2019-07-27 21:50:59 +02:00
sysctl_net_ipv4.c ipv4: Return EINVAL when ping_group_range sysctl doesn't map to user ns 2019-07-27 21:50:25 +02:00
sysfs_net_ipv4.c
…
tcp.c tcp: avoid fastopen API to be used on AF_UNSPEC 2019-07-27 21:51:31 +02:00
tcp_bic.c
…
tcp_cong.c tcp: disallow cwnd undo when switching congestion control 2019-07-27 21:44:29 +02:00
tcp_cubic.c tcp_cubic: do not set epoch_start in the future 2017-04-18 12:17:39 +02:00
tcp_diag.c net: diag: Support destroying TCP sockets. 2016-05-18 14:36:07 +05:30
tcp_fastopen.c
…
tcp_highspeed.c
…
tcp_htcp.c
…
tcp_hybla.c
…
tcp_illinois.c
…
tcp_input.c tcp: don't read out-of-bounds opsize 2019-07-27 21:52:04 +02:00
tcp_ipv4.c net: inet: Support UID-based routing in IP protocols. 2019-07-27 21:50:59 +02:00
tcp_lp.c tcp: fix wraparound issue in tcp_lp 2019-07-27 21:44:45 +02:00
tcp_memcontrol.c
…
tcp_metrics.c
…
tcp_minisocks.c tcp: remove BUG_ON() in tcp_check_req() 2019-07-27 21:51:29 +02:00
tcp_output.c tcp: purge write queue in tcp_connect_init() 2019-07-27 21:49:11 +02:00
tcp_probe.c
…
tcp_scalable.c
…
tcp_timer.c tcp: fix various issues for sockets morphing to listen state 2019-07-27 21:44:00 +02:00
tcp_vegas.c
…
tcp_vegas.h
…
tcp_veno.c
…
tcp_westwood.c
…
tcp_yeah.c tcp_yeah: don't set ssthresh below 2 2016-01-28 21:49:34 -08:00
tunnel4.c
…
udp.c net: udp: do not report ICMP redirects to user space 2019-07-27 21:51:42 +02:00
udp_diag.c net: inet: diag: expose the socket mark to privileged processes. 2019-07-27 21:50:56 +02:00
udp_impl.h
…
udplite.c
…
xfrm4_input.c xfrm: Reinject transport-mode packets through tasklet 2019-07-27 21:46:20 +02:00
xfrm4_mode_beet.c
…
xfrm4_mode_transport.c
…
xfrm4_mode_tunnel.c
…
xfrm4_output.c
…
xfrm4_policy.c BACKPORT: net: xfrm: support setting an output mark. 2019-07-27 21:51:33 +02:00
xfrm4_state.c
…
xfrm4_tunnel.c
…