mirror of
https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git
synced 2024-10-19 09:59:04 +00:00
6d381634d2
As reported by Mark Dowd <Mark_Dowd@McAfee.com>, ip6_tables is susceptible to a fragmentation attack causing false negatives on extension header matches. When extension headers occur in the non-first fragment after the fragment header (possibly with an incorrect nexthdr value in the fragment header) a rule looking for this extension header will never match. Drop fragments that are at offset 0 and don't contain the final protocol header regardless of the ruleset, since this should not happen normally. Since all extension headers are before the protocol header this makes sure an extension header is either not present or in the first fragment, where we can properly parse it. With help from Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
140 lines
3.4 KiB
C
140 lines
3.4 KiB
C
/* Kernel module to match AH parameters. */
|
|
|
|
/* (C) 2001-2002 Andras Kis-Szabo <kisza@sch.bme.hu>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/ip.h>
|
|
#include <linux/ipv6.h>
|
|
#include <linux/types.h>
|
|
#include <net/checksum.h>
|
|
#include <net/ipv6.h>
|
|
|
|
#include <linux/netfilter_ipv6/ip6_tables.h>
|
|
#include <linux/netfilter_ipv6/ip6t_ah.h>
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("IPv6 AH match");
|
|
MODULE_AUTHOR("Andras Kis-Szabo <kisza@sch.bme.hu>");
|
|
|
|
#if 0
|
|
#define DEBUGP printk
|
|
#else
|
|
#define DEBUGP(format, args...)
|
|
#endif
|
|
|
|
/* Returns 1 if the spi is matched by the range, 0 otherwise */
|
|
static inline int
|
|
spi_match(u_int32_t min, u_int32_t max, u_int32_t spi, int invert)
|
|
{
|
|
int r=0;
|
|
DEBUGP("ah spi_match:%c 0x%x <= 0x%x <= 0x%x",invert? '!':' ',
|
|
min,spi,max);
|
|
r = (spi >= min && spi <= max) ^ invert;
|
|
DEBUGP(" result %s\n",r? "PASS\n" : "FAILED\n");
|
|
return r;
|
|
}
|
|
|
|
static int
|
|
match(const struct sk_buff *skb,
|
|
const struct net_device *in,
|
|
const struct net_device *out,
|
|
const struct xt_match *match,
|
|
const void *matchinfo,
|
|
int offset,
|
|
unsigned int protoff,
|
|
int *hotdrop)
|
|
{
|
|
struct ip_auth_hdr *ah, _ah;
|
|
const struct ip6t_ah *ahinfo = matchinfo;
|
|
unsigned int ptr;
|
|
unsigned int hdrlen = 0;
|
|
int err;
|
|
|
|
err = ipv6_find_hdr(skb, &ptr, NEXTHDR_AUTH, NULL);
|
|
if (err < 0) {
|
|
if (err != -ENOENT)
|
|
*hotdrop = 1;
|
|
return 0;
|
|
}
|
|
|
|
ah = skb_header_pointer(skb, ptr, sizeof(_ah), &_ah);
|
|
if (ah == NULL) {
|
|
*hotdrop = 1;
|
|
return 0;
|
|
}
|
|
|
|
hdrlen = (ah->hdrlen + 2) << 2;
|
|
|
|
DEBUGP("IPv6 AH LEN %u %u ", hdrlen, ah->hdrlen);
|
|
DEBUGP("RES %04X ", ah->reserved);
|
|
DEBUGP("SPI %u %08X\n", ntohl(ah->spi), ntohl(ah->spi));
|
|
|
|
DEBUGP("IPv6 AH spi %02X ",
|
|
(spi_match(ahinfo->spis[0], ahinfo->spis[1],
|
|
ntohl(ah->spi),
|
|
!!(ahinfo->invflags & IP6T_AH_INV_SPI))));
|
|
DEBUGP("len %02X %04X %02X ",
|
|
ahinfo->hdrlen, hdrlen,
|
|
(!ahinfo->hdrlen ||
|
|
(ahinfo->hdrlen == hdrlen) ^
|
|
!!(ahinfo->invflags & IP6T_AH_INV_LEN)));
|
|
DEBUGP("res %02X %04X %02X\n",
|
|
ahinfo->hdrres, ah->reserved,
|
|
!(ahinfo->hdrres && ah->reserved));
|
|
|
|
return (ah != NULL)
|
|
&&
|
|
(spi_match(ahinfo->spis[0], ahinfo->spis[1],
|
|
ntohl(ah->spi),
|
|
!!(ahinfo->invflags & IP6T_AH_INV_SPI)))
|
|
&&
|
|
(!ahinfo->hdrlen ||
|
|
(ahinfo->hdrlen == hdrlen) ^
|
|
!!(ahinfo->invflags & IP6T_AH_INV_LEN))
|
|
&&
|
|
!(ahinfo->hdrres && ah->reserved);
|
|
}
|
|
|
|
/* Called when user tries to insert an entry of this type. */
|
|
static int
|
|
checkentry(const char *tablename,
|
|
const void *entry,
|
|
const struct xt_match *match,
|
|
void *matchinfo,
|
|
unsigned int hook_mask)
|
|
{
|
|
const struct ip6t_ah *ahinfo = matchinfo;
|
|
|
|
if (ahinfo->invflags & ~IP6T_AH_INV_MASK) {
|
|
DEBUGP("ip6t_ah: unknown flags %X\n", ahinfo->invflags);
|
|
return 0;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
static struct ip6t_match ah_match = {
|
|
.name = "ah",
|
|
.match = match,
|
|
.matchsize = sizeof(struct ip6t_ah),
|
|
.checkentry = checkentry,
|
|
.me = THIS_MODULE,
|
|
};
|
|
|
|
static int __init ip6t_ah_init(void)
|
|
{
|
|
return ip6t_register_match(&ah_match);
|
|
}
|
|
|
|
static void __exit ip6t_ah_fini(void)
|
|
{
|
|
ip6t_unregister_match(&ah_match);
|
|
}
|
|
|
|
module_init(ip6t_ah_init);
|
|
module_exit(ip6t_ah_fini);
|