Yi Yang 53391fa20c cpufreq: fix obvious condition statement error ... The function __cpufreq_set_policy in file drivers/cpufreq/cpufreq.c has a very obvious error: if (policy->min > data->min && policy->min > policy->max) { ret = -EINVAL; goto error_out; } This condtion statement is wrong because it returns -EINVAL only if policy->min is greater than policy->max (in this case, "policy->min > data->min" is true for ever.). In fact, it should return -EINVAL as well if policy->max is less than data->min. The correct condition should be: if (policy->min > data->max || policy->max < data->min) { The following test result testifies the above conclusion: Before applying this patch: [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies 2394000 1596000 [root@yangyi-dev /]# echo 1596000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 1596000 [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq 1596000 [root@yangyi-dev /]# echo "2000000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq -bash: echo: write error: Invalid argument [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq 1596000 [root@yangyi-dev /]# echo "0" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 1596000 [root@yangyi-dev /]# echo "1595000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 1596000 [root@yangyi-dev /]# After applying this patch: [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_frequencies 2394000 1596000 [root@yangyi-dev /]# echo 1596000 > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 1596000 [root@yangyi-dev /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq 1596000 [root@localhost /]# echo "2000000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq -bash: echo: write error: Invalid argument [root@localhost /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_min_freq 1596000 [root@localhost /]# echo "0" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq -bash: echo: write error: Invalid argument [root@localhost /]# echo "1595000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq -bash: echo: write error: Invalid argument [root@localhost /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 1596000 [root@localhost /]# echo "1596000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@localhost /]# echo "2394000" > /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq [root@localhost /]# cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_max_freq 2394000 [root@localhost /] Signed-off-by: Yi Yang <yi.y.yang@intel.com> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>		2008-01-30 13:33:34 +01:00
..
acorn/char
acpi	x86: don't disable TSC in any C states on AMD Fam10h	2008-01-30 13:32:41 +01:00
amba
ata
atm
auxdisplay
base
block	cciss: fix bug in overriding ->data_len before completion	2008-01-29 21:55:18 +01:00
bluetooth
cdrom
char	rtc: use the IRQ callback interface in (old) RTC driver	2008-01-30 13:33:31 +01:00
clocksource
connector	[NETNS]: Consolidate kernel netlink socket destruction.	2008-01-28 15:08:07 -08:00
cpufreq	cpufreq: fix obvious condition statement error	2008-01-30 13:33:34 +01:00
cpuidle
crypto
dca
dio
dma
edac
eisa
firewire
firmware	x86: left over fix for leak of early_ioremp in dmi_scan	2008-01-30 13:33:32 +01:00
hid
hwmon
i2c
ide
ieee1394
infiniband	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.25	2008-01-29 22:54:01 +11:00
input	x86: replace outb_p() with udelay(2) in drivers/input/mouse/pc110pad.c	2008-01-30 13:31:24 +01:00
isdn
kvm	x86: get rid of _MASK flags	2008-01-30 13:31:27 +01:00
leds
lguest	x86: use generic register name in the thread and tss structures	2008-01-30 13:31:02 +01:00
macintosh
mca
md
media
message
mfd
misc
mmc
mtd
net	Mostly revert "e1000/e1000e: Move PCI-Express device IDs over to e1000e"	2008-01-30 09:54:54 +11:00
nubus
of
oprofile
parisc
parport
pci
pcmcia
pnp	git-x86: drivers/pnp/pnpbios/bioscalls.c build fix	2008-01-30 13:32:31 +01:00
power
ps3
rapidio
rtc
s390	[VLAN]: Turn VLAN_DEV_INFO into inline function	2008-01-28 15:08:32 -08:00
sbus
scsi	[NETNS]: Consolidate kernel netlink socket destruction.	2008-01-28 15:08:07 -08:00
serial
sh
sn
spi
ssb	ssb: Add boardflags_hi field to the sprom data structure	2008-01-28 15:09:52 -08:00
tc
telephony
uio
usb
video
virtio
w1
watchdog
xen
zorro
Kconfig
Makefile