mirror of
https://github.com/team-infusion-developers/android_kernel_samsung_msm8976.git
synced 2024-11-01 10:33:27 +00:00
bbeed681a5
commit db181ce011e3c033328608299cd6fac06ea50130 upstream. Kenton Varda <kenton@sandstorm.io> discovered that by remounting a read-only bind mount read-only in a user namespace the MNT_LOCK_READONLY bit would be cleared, allowing an unprivileged user to the remount a read-only mount read-write. Upon review of the code in remount it was discovered that the code allowed nosuid, noexec, and nodev to be cleared. It was also discovered that the code was allowing the per mount atime flags to be changed. The first naive patch to fix these issues contained the flaw that using default atime settings when remounting a filesystem could be disallowed. To avoid this problems in the future add tests to ensure unprivileged remounts are succeeding and failing at the appropriate times. Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
17 lines
478 B
Makefile
17 lines
478 B
Makefile
# Makefile for mount selftests.
|
|
|
|
all: unprivileged-remount-test
|
|
|
|
unprivileged-remount-test: unprivileged-remount-test.c
|
|
gcc -Wall -O2 unprivileged-remount-test.c -o unprivileged-remount-test
|
|
|
|
# Allow specific tests to be selected.
|
|
test_unprivileged_remount: unprivileged-remount-test
|
|
@if [ -f /proc/self/uid_map ] ; then ./unprivileged-remount-test ; fi
|
|
|
|
run_tests: all test_unprivileged_remount
|
|
|
|
clean:
|
|
rm -f unprivileged-remount-test
|
|
|
|
.PHONY: all test_unprivileged_remount
|