79bd202987
commit a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e upstream. We need to consistently enforce that keyed hashes cannot be used without setting the key. To do this we need a reliable way to determine whether a given hash algorithm is keyed or not. AF_ALG currently does this by checking for the presence of a ->setkey() method. However, this is actually slightly broken because the CRC-32 algorithms implement ->setkey() but can also be used without a key. (The CRC-32 "key" is not actually a cryptographic key but rather represents the initial state. If not overridden, then a default initial state is used.) Prepare to fix this by introducing a flag CRYPTO_ALG_OPTIONAL_KEY which indicates that the algorithm has a ->setkey() method, but it is not required to be called. Then set it on all the CRC-32 algorithms. The same also applies to the Adler-32 implementation in Lustre. Also, the cryptd and mcryptd templates have to pass through the flag from their underlying algorithm. Change-Id: Ie0547047b828f276d967e8979cd9176e57c99ac8 Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> [bwh: Backported to 3.2: - Drop changes to nonexistent drivers - There's no CRYPTO_ALG_INTERNAL flag - Adjust filenames] Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
||
|---|---|---|
| .. | ||
| amcc | ||
| caam | ||
| msm | ||
| nx | ||
| ux500 | ||
| Kconfig | ||
| Makefile | ||
| atmel-aes-regs.h | ||
| atmel-aes.c | ||
| atmel-sha-regs.h | ||
| atmel-sha.c | ||
| atmel-tdes-regs.h | ||
| atmel-tdes.c | ||
| bfin_crc.c | ||
| geode-aes.c | ||
| geode-aes.h | ||
| hifn_795x.c | ||
| ixp4xx_crypto.c | ||
| mv_cesa.c | ||
| mv_cesa.h | ||
| n2_asm.S | ||
| n2_core.c | ||
| n2_core.h | ||
| omap-aes.c | ||
| omap-sham.c | ||
| padlock-aes.c | ||
| padlock-sha.c | ||
| picoxcell_crypto.c | ||
| picoxcell_crypto_regs.h | ||
| s5p-sss.c | ||
| sahara.c | ||
| talitos.c | ||
| talitos.h | ||
| tegra-aes.c | ||
| tegra-aes.h | ||