From 826e198cc41574c3c4c2aea7d55cb2457dd2b517 Mon Sep 17 00:00:00 2001 From: Andreas Eriksson Date: Mon, 15 Nov 2021 23:48:04 +0100 Subject: [PATCH] =?UTF-8?q?test:=20=F0=9F=92=8D=20Remove=20warnings=20abou?= =?UTF-8?q?t=20timers=20not=20beeing=20mocked=20(#540)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The jest.advanceTimersToNextTimer() is not needed by the tests, they pass without it. The reason the warnings was not seen before was because we used an older version of jest (26) before. Now with NX we use 27. --- libs/hooks/src/useCalendar.test.js | 4 ---- libs/hooks/src/useChildList.test.js | 4 ---- libs/hooks/src/useClassmates.test.js | 4 ---- libs/hooks/src/useEtjanstChildren.test.js | 4 ---- libs/hooks/src/useMenu.test.js | 4 ---- libs/hooks/src/useNews.test.js | 4 ---- libs/hooks/src/useNewsDetails.test.js | 4 ---- libs/hooks/src/useNotifications.test.js | 4 ---- libs/hooks/src/useSchedule.test.js | 4 ---- libs/hooks/src/useSkola24Children.test.js | 4 ---- libs/hooks/src/useTimetable.test.js | 4 ---- libs/hooks/src/useUser.test.js | 4 ---- 12 files changed, 48 deletions(-) diff --git a/libs/hooks/src/useCalendar.test.js b/libs/hooks/src/useCalendar.test.js index 7d692751..d1e203f7 100644 --- a/libs/hooks/src/useCalendar.test.js +++ b/libs/hooks/src/useCalendar.test.js @@ -191,8 +191,6 @@ describe('useCalendar(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -222,8 +220,6 @@ describe('useCalendar(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useChildList.test.js b/libs/hooks/src/useChildList.test.js index db5202bb..a0d97051 100644 --- a/libs/hooks/src/useChildList.test.js +++ b/libs/hooks/src/useChildList.test.js @@ -223,8 +223,6 @@ describe('useChildList()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual(echildrenCache) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -264,8 +262,6 @@ describe('useChildList()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual(echildrenCache) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useClassmates.test.js b/libs/hooks/src/useClassmates.test.js index 75d085af..d0007477 100644 --- a/libs/hooks/src/useClassmates.test.js +++ b/libs/hooks/src/useClassmates.test.js @@ -176,8 +176,6 @@ describe('useClassmates(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -207,8 +205,6 @@ describe('useClassmates(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useEtjanstChildren.test.js b/libs/hooks/src/useEtjanstChildren.test.js index 883ddd5e..a70ff058 100644 --- a/libs/hooks/src/useEtjanstChildren.test.js +++ b/libs/hooks/src/useEtjanstChildren.test.js @@ -174,8 +174,6 @@ describe('useEtjanstChildren()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -205,8 +203,6 @@ describe('useEtjanstChildren()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useMenu.test.js b/libs/hooks/src/useMenu.test.js index a643bd44..60ac912a 100644 --- a/libs/hooks/src/useMenu.test.js +++ b/libs/hooks/src/useMenu.test.js @@ -172,8 +172,6 @@ describe('useMenu(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -202,8 +200,6 @@ describe('useMenu(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useNews.test.js b/libs/hooks/src/useNews.test.js index 4d5520e4..c8c19e4a 100644 --- a/libs/hooks/src/useNews.test.js +++ b/libs/hooks/src/useNews.test.js @@ -172,8 +172,6 @@ describe('useNews(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -202,8 +200,6 @@ describe('useNews(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useNewsDetails.test.js b/libs/hooks/src/useNewsDetails.test.js index 25a5c753..4bb718f1 100644 --- a/libs/hooks/src/useNewsDetails.test.js +++ b/libs/hooks/src/useNewsDetails.test.js @@ -192,8 +192,6 @@ describe('useNewsDetails(child, newsItem)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual({ ...cached }) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -223,8 +221,6 @@ describe('useNewsDetails(child, newsItem)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual({ ...cached }) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useNotifications.test.js b/libs/hooks/src/useNotifications.test.js index 4e1f6df5..e6d14648 100644 --- a/libs/hooks/src/useNotifications.test.js +++ b/libs/hooks/src/useNotifications.test.js @@ -176,8 +176,6 @@ describe('useNotifications(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -207,8 +205,6 @@ describe('useNotifications(child)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useSchedule.test.js b/libs/hooks/src/useSchedule.test.js index 5df4ac3d..7397b192 100644 --- a/libs/hooks/src/useSchedule.test.js +++ b/libs/hooks/src/useSchedule.test.js @@ -192,8 +192,6 @@ describe('useSchedule(child, from, to)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -223,8 +221,6 @@ describe('useSchedule(child, from, to)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useSkola24Children.test.js b/libs/hooks/src/useSkola24Children.test.js index 292ba7f2..b0fb65b7 100644 --- a/libs/hooks/src/useSkola24Children.test.js +++ b/libs/hooks/src/useSkola24Children.test.js @@ -178,8 +178,6 @@ describe('useSkola24Children()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ personGuid: '2' }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -209,8 +207,6 @@ describe('useSkola24Children()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ personGuid: '2' }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useTimetable.test.js b/libs/hooks/src/useTimetable.test.js index b08ea527..c2709996 100644 --- a/libs/hooks/src/useTimetable.test.js +++ b/libs/hooks/src/useTimetable.test.js @@ -191,8 +191,6 @@ describe('useTimetable(child, week, year, lang)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -222,8 +220,6 @@ describe('useTimetable(child, week, year, lang)', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual([{ id: 2 }]) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() diff --git a/libs/hooks/src/useUser.test.js b/libs/hooks/src/useUser.test.js index efe2c80a..71888854 100644 --- a/libs/hooks/src/useUser.test.js +++ b/libs/hooks/src/useUser.test.js @@ -162,8 +162,6 @@ describe('useUser()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual({ id: 2 }) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate() @@ -192,8 +190,6 @@ describe('useUser()', () => { expect(result.current.status).toEqual('loading') expect(result.current.data).toEqual({ id: 2 }) - jest.advanceTimersToNextTimer() - await waitForNextUpdate() await waitForNextUpdate() await waitForNextUpdate()