When a interrupt for data event is received, it is possible that the SMD
packet could have been processed on other core executing with interrupts
locked. In this case, the data event would have scheduled a workqueue
which would result in 0 bytes for packet size. This is a valid scenario
and shouldn't throw a bug.
Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
(cherry picked from commit 137cd700c1524ee274118d5dd6055d3673a2e8f7)
Change-Id: I90efeaa814ebec82542e46c35df754a1f380251c
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
This change allows kernel thermal mitigation to read sensors
that are not the main sensor (TSENS0) even after the driver probe
occurs.
Signed-off-by: Eugene Seah <eseah@codeaurora.org>
(cherry picked from commit bf8b0777937ab5f06f81d7b26cb7226f69099f70)
Change-Id: I4ab19b6b7604344f91700340115dcf6c4ecfe820
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
The LDO_H_MODE_1 is reset bandgap off mode. This needs to be reconfigured
for audio mode.
CRs-Fixed: 378182
Signed-off-by: Asish Bhattacharya <asishb@codeaurora.org>
(cherry picked from commit 63032b49f45f61660a46acd61bbf529d62ea4d36)
Change-Id: I9fd94624619efc615141f720d8de93e21eafe97a
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
This change is needed for mainlining of USB accessory support
from GOOGLE.
Change-Id: Ib11cfa8f62d669fe3be1c9ac0763800c7a1b1d40
Signed-off-by: Amit Blay <ablay@codeaurora.org>
(cherry picked from commit 8bd10dc4b17c551acaf12a76933f86abeaa3fc13)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Found in a rare case there is possibility that remote device
sent disconnect on a connection and DUT is trying send data
on the same. In that case accessing some released wakelock
is causing issue. The current changes are to use locking
mechanism to validate the connection before acting on the
wake lock.
CRs-Fixed: 394651
Change-Id: I6a4188a7d0d05a8cfbe66d3680473d549157917a
Signed-off-by: Srinivas Krovvidi <skrovvid@codeaurora.org>
(cherry picked from commit 6aadc41fcbd28dc3899a4b5d098e5f316588a029)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
This change addresses following enhancements to debug
logging:-
1) Add data payload logging which is not currently
supported. This helps to sniff first 32 bytes of data
being sent and received. Data payload logging is
enabled by default. To disable data payload logging:-
echo 0 > /sys/module/ehci_hcd/parameters/enable_payload_log
2) Current urb submission event logging does not cover
root hub submissions, hence move urb submission logging
to hcd driver.
3) Current urb submission event logging does not return
the correct status if submission fails. Hence log the
return status of urb submission.
CRs-Fixed: 393294
Change-Id: Ic7e555e1545ec7d7b0e4042cd35235e0af26fb01
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
(cherry picked from commit 4d50a43dce8645955d8ed739d7a183e62922c721)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
In hci_connect API there is check for existing link, before
connect operation in order to avoid queuing connect if connection
already exist. This check for Synchronous connections is not
validating for ESCO and SCO connection types which are possible
synchronous connections.The current change takes care of verifying
both before proceeding to add a new connection.
Change-Id: I9018e0938bcd222bb6d80944e1b113e07227b066
Signed-off-by: Srinivas Krovvidi <skrovvid@codeaurora.org>
(cherry picked from commit 645f4d465ba131c87a99fdebcef5e597181b33c8)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
CPR should have an option to be disabled at boot if required.
Usage: Append "msm-cpr.enable=0" to the kernel commandline to
disable CPR. Append "msm-cpr.enable=1" to enable CPR.
Change-Id: Idaac721063184abcfb37ae1ea33870f2464d70f0
Signed-off-by: Kaushal Kumar <kaushalk@codeaurora.org>
(cherry picked from commit 5d83a9e81a449fd8eab5071226fcbdfdfe6b9857)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
When doing RPM assisted PC, with L2 in power collapse, the Krait PMIC
FTS gang can also be disabled. Configure PMIC_DATA1 to disable the gang
and PMIC_DATA0 to enable the gang. These data registers are used by SPM
sequence when doing RPM assisted power collapse with L2 power collapse.
Also, the PMIC delay after the PMIC SPM command is now part of PMIC_DATAn
commands in SAW v2.2. Remove these unused PMIC_DATAn values from the
device tree.
Signed-off-by: Praveen Chidambaram <pchidamb@codeaurora.org>
(cherry picked from commit 32e3a9e652c9d6603155db382cbd747b6db15d27)
Conflicts:
arch/arm/boot/dts/msm8974_pm.dtsi
Change-Id: I6604fdac1df7c7d943d0a5c6f196f8a4df390258
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
If a clock is prepared and not enabled we don't print information
about that clock in the debug_suspend feature. Fix the code to
consider unprepared as the only case to bail out early and also
update the printk to display the prepare count and enable count.
Change-Id: Ie7b5527c17339e48b93dd6354fed132679351d18
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
(cherry picked from commit 9d96ae5c2bd779f0590565d137030eb4c367a28f)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
When the remote subsystem is in reset, the SMD_PKT driver logs a message
everytime the user-space modules perform operations using that driver.
Update the SMD_PKT driver to log only once when the remote subsystem is in
reset.
Change-Id: I4cb1c52c549cd8b40d3a0c22437b0faaccd1ed75
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@codeaurora.org>
(cherry picked from commit a6dc4b0d5a0fda26fcfded695af106192034cbf7)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Add dummy socinfo and support to get socinfo from bootloader for
msm8226
Signed-off-by: Syed Rameez Mustafa <rameezmustafa@codeaurora.org>
(cherry picked from commit d6084d3139d432f53f8c1b465dd81d7073b7a3c6)
Conflicts:
arch/arm/mach-msm/include/mach/socinfo.h
arch/arm/mach-msm/socinfo.c
Change-Id: I945a1ff75706df9220177fc350a568491fb26f5b
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Currently the log is output after callback is returned from the
client driver. Output the log first so that we could know the
callback is executed.
Change-Id: If9183b364d518f8b426b94f58556232605575714
Signed-off-by: Yan He <yanhe@codeaurora.org>
(cherry picked from commit 93fe9147cd2f053880a0156892328e290088cd65)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
There is a possibility of receiving a release interrupt
before press when both these actions (press and release) of the
power-key are very close-by (~1-2ms) to the debounce time
of the key. Handle this case by maintaining a state variable.
Also mark the release interrupt as a wakeup source to
wakeup the system when the above mentioned abnormal case
occurs.
CRs-Fixed: 394289
Change-Id: I74475c1e5159dd30e52aca91243eec7e2fac4d57
Signed-off-by: Anirudh Ghayal <aghayal@codeaurora.org>
(cherry picked from commit 306e3197b5cc657a62c41823fb6cd03600d35f3f)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
If PM resume and Wakeup irq happen at same time
its possible to disable wakeup irq twice. Prevent
the same by protecting with spinlock
CRs-Fixed: 396895
Change-Id: I3320478d6c770787bc571964f4a38dce6927af63
Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
(cherry picked from commit d343c01025fc3bb597fbb60c8fc4369cc17cbf5d)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Leading zeros in register offsets is not acceptable
while naming device nodes in device tree. Fix this in
msm_qpic_nand.txt device tree binding.
Change-Id: Iab8f339b8e98d06c5197b794640fddca0e153960
Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
(cherry picked from commit 152eff18c93c014cd8885fed38f0e6eeb89032ee)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
HSIC controller should send SOF with in 3 msec after completing
the resume signal. If processor is in idle sleep state, the timer
interrupt generated by HSIC controller to indicate resume completion
gets delayed. If the interrupt handler is not run with in 3msec
after resume, the resume sequence is repeated. Disallow processor
idle sleep to avoid multiple resume cycles.
CRs-Fixed: 397154
Change-Id: Ibc8965ad8bcd94e0b1b1d39b5b2ad8f39cf51095
Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
(cherry picked from commit 4f5dc3be7b2b9939bc7a1b9526ccb70d93b53361)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
If one process calls sys_reboot and that process then stops other
CPUs while those CPUs are within a spin_lock() region we can
potentially encounter a deadlock scenario like below.
CPU 0 CPU 1
----- -----
spin_lock(my_lock)
smp_send_stop()
send_IPI handle_IPI()
disable_preemption/irqs
while(1);
<PREEMPT>
spin_lock(my_lock) <--- Waits forever
We shouldn't attempt to run any other tasks after we send a stop
IPI to a CPU so disable preemption so that this task runs to
completion.
Change-Id: I528af0b4448433bd9d6ca12d6a0e2c422a55d4be
CRs-Fixed: 396169
Reported-by: Sundarajan Srinivasan <sundaraj@codeaurora.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
(cherry picked from commit 78e9b56740ad789351b6d15cd9a67fe03091a3a1)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Allow the ks8851 driver to configure regulators and GPIOs
specified as platform data or in device tree.
Change-Id: I806f7c22ba4b75eb26720704968cdec9cd7796c8
Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Signed-off-by: Stepan Moskovchenko <stepanm@codeaurora.org>
(cherry picked from commit c990b2faa3ce0b4f2361630a687abdedee4241a9)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
When msm_cpufreq_target() is called without holding the policy
semaphore, there is a rare chance that the cpu gets hotplugged in
the acpuclk_set_rate. The probability of this issue increases
when cross-calling is used or using interactive governor which
tries to set all cpu frequencies from a single thread.
Add a hotplug notifier and set the device_suspended flag holding
the suspend mutex, when cpu is going down. This mutex is always
held when frequency changes are done.
Change-Id: Ide3aa6927ad60d2512d63761c51bb15117461250
Signed-off-by: Narayanan Gopalakrishnan <nargop@codeaurora.org>
(cherry picked from commit 56f5a6de7f2ab48ed0538da727ad52673fb801a2)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Add support for properly parsing word aligned access channels in the
subsystem restart functionality. This allows apps to properly reset
channels between a crashed subsystem and another subsystem which requires
word aligned accesses.
CRs-Fixed: 398445
Change-Id: Ib199643972725600dd706193f00f5f58a5695250
Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
(cherry picked from commit 00be62893bb8c2820104b27dafc2532cca54bef4)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Currently, bus scaling topology for qseecom is incorrect.
-Added the correct topology paths for accessing Crypto
Engine which is controlled by QSEE.
-Removed setting the clock frequency of DFAB. This is
done by the bus driver.
-Removed references to the dfab clock instance defined
in clocks file.
Change-Id: Ib6953ea3bf5721d458bfe2aa06c54be329a8fdb9
Signed-off-by: Ramesh Masavarapu <rameshm@codeaurora.org>
(cherry picked from commit 1e8c7242fd3f32ade703484d2113f4a6f442a0e8)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
find_cur_l2_level() assumes that the L2 table is NULL terminated
when it has never been terminated. Therefore, if the rate that is
read from the hardware during boot is not found in the table we
will run off the end of the table and read potential junk values.
NULL terminate all the L2 tables so that the loop in
find_cur_l2_level() is guaranteed to terminate.
Change-Id: Ia5d0213000b44def35e388fd3cadf0293344257b
Reported-by: Laura Abbot <lauraa@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
(cherry picked from commit 791bca96241d7e1371a46c78838961ce2f511d36)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Remove the time out in the wait_for_ack_noirq API until the RPM
messaging framework is profiled and optimized.
Change-Id: Ib1a0df3b1cae9c3ed6b7a932fa5ad3680f88e641
Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
(cherry picked from commit 2ff713da330d38e7c539daa5d69b368c6567b006)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
The modem subsystem restart driver should not be init'ed
on the 8064 alone. Other targets that share the same binary
are OK. Simplify the cpu_is check to only fail if the target
is an 8064.
Change-Id: I208b25bcc62d3e162db3f9468dc873244aaaeb24
Signed-off-by: Vikram Mulukutla <markivx@codeaurora.org>
(cherry picked from commit 3555cb99847a03e8f8dfc8d01a20d72b264e7586)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
This change adds module param which allows to disable RNDIS
Multi-packet Feature (Aggregation support in Downlink path)
as this feature is enabled by default.
To disable use this param before moving to RNDIS Composition:
echo 1 > /sys/module/g_android/parameters/rndis_multipacket_dl_disable
Also counts errors as Rx errors if received RNDIS packets are
not following RNDIS message format as those packets are being
discarded.
Change-Id: I2c99409f689c131cf92c4967235643d001d90773
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
(cherry picked from commit 93df275e337ee68a5561bcf3c8eafdc35d455b81)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
- Sometimes user data getting corrupted and it is not available
at the kernel level
- Use the kernel buffer instead of user space buffer to copy
the data from fifo.
- Increase the STD_BUF_SIZE buffer size from 64 to 128 bytes to compatible
with Frameworks buffer size
Change-Id: I1e0fd8e59b218e7bec7820b0c27e2405d472cd56
Signed-off-by: Venkateshwarlu Domakonda <Venkateshwarlu@codeaurora.org>
(cherry picked from commit 7f095c44d4f63b168820aeba9d72b2504a879ab9)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Configure the spi clk, mosi, miso, cs gpio's on per
transaction basis and unconfigure otherwise.
It will remove the conflicts if same gpio's are
being used by different modules if no SPI device
is present.
CRs-Fixed: 387043
Change-Id: Ib5c3bfbd13681f4aee0c4a815b19f423c586e160
Signed-off-by: Alok Chauhan <alokc@codeaurora.org>
(cherry picked from commit 66554a1317d40fbacd1a7e1e3210de8fb947ad57)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Move from multitouch protocol A to protocol B, and since some
applications are not working under BTN_2 reporting, all the instances
of HAT are removed along with BTN_2 reporting.
Change-Id: I25c9c811078452eb9ff11159d0f45c9e3f831849
Signed-off-by: Amy Maloche <amaloche@codeaurora.org>
Signed-off-by: Shantanu Jain <shjain@codeaurora.org>
(cherry picked from commit 94f65fcf5d89b7943777750b2e358c7421f26400)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
CAD(Common Application Devices) support is added on modem.
Add CAD sound device list in board file to support the same.
Change-Id: If794eb077c20f258068569a29664526c8375e70e
Signed-off-by: Manish Dewangan <manish@codeaurora.org>
(cherry picked from commit 1c0fa49d34c2b756b4d47cb473b66b262739b84f)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
ION reservation at boot-time is subject to change via
early parameter or dynamically at runtime. So, let's
not define all the sizes rigidly via macros, instead
use variables.
Change-Id: I46ac6ad2365e45de264041cf11a6c9daba837779
Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
(cherry picked from commit cb0a07a12c002d2f4d757466663c67bc34cb3152)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
This change extends the existing boot parameter that specifies
the external display to add the capability to enable the
MHL transmitter.
Change-Id: I062bb68c7b94bc0f84771f5fafe7208d0a362484
Signed-off-by: Aravind Venkateswaran <aravindh@codeaurora.org>
(cherry picked from commit de80944923f84837afc9f83ba11cb251a5d59aef)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Use PM8917 GPIO 26 to enable and disable the LCD backlight on
targets which use PM8917 since PWM control is not available.
Change-Id: Ic0a2b840e41e3c4ec90af3cbee2d3f494623bc63
Signed-off-by: David Collins <collinsd@codeaurora.org>
(cherry picked from commit d992d3144a0cd09d7653d9c9f556c1afa20a5f7f)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
The regulator power grid changes slightly when using a PM8917 in
place of a PM8921 on 8064 targets. Add configuration data so
that regulators present only on PM8917 are registered when a
PM8917 chip is detected. Also remove PM8921 only regulators when
PM8917 is detected. Modify the USB OTG MVS supply chain to
handle the replacement of an external 5V boost regulator with the
boost present inside of the PM8917.
Increase the max_uV value requested in the wlan_riva driver for
the iris_vdddig supply to 1225000 in order to handle the case of
this supply coming from the S1 regulator in the PM8917
configuration. The S1 regulator only supports 1225000 uV.
Change-Id: Ib5ffa76cbc4590f468003c6863ba73807c4879e7
Signed-off-by: David Collins <collinsd@codeaurora.org>
(cherry picked from commit 793793b277040989d494921ac12cd4bf99939b76)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
A new socinfo format version 7 is added with support for pmic_model and
pmic_die_revision. Adding the corresponding socinfo API to support them.
Change-Id: I6da3ec41da307c72946945bdb10a31e65205a7e1
Signed-off-by: Jin Hong <jinh@codeaurora.org>
(cherry picked from commit 9b556c3aea6433415759e4af4feda74c58c4c3ad)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
PMIC PM8917 has more GPIOs and MPPs than PM8038. Since the
Linux GPIO address space is determined at compile time for
MSM8930, empty mappings must be added to allow for the
additional PM8917 GPIOs and MPPs. Modify the PM8038 GPIO and MPP
mapping macros to provide the space needed for PM8917 GPIOs and
MPPs.
Change-Id: Ib1e05841ccd7b82d576d8b20a7cc7bd601dd1661
Signed-off-by: David Collins <collinsd@codeaurora.org>
(cherry picked from commit fc7367294dfaf2e4ce2ae446e3de2280a4f4e921)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Rename board-8930-regulator.c to board-8930-regulator-pm8038.c so
that regulator mappings can be made PMIC specific in order to
handle PM8038 vs PM8917 mapping at runtime.
Change-Id: I6b4bb822ff3a7e50b7b5f7f1a339459015e6908c
Signed-off-by: David Collins <collinsd@codeaurora.org>
(cherry picked from commit 3f91701fdcc8ae218214890f5dab5e77cd935f4e)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
When using PM8917 with MSM8930, the Sitar CODEC CDC_VPP_CP
supply, PM8917 SMPS 4, is configured to work at only 1.8 V.
Therefore, change the min_uV value that is requested for
CDC_VDD_CP to 1.8 V to accommodate the lower set point.
Change-Id: I48016fa8b281e529935885dfd316ae838fbe16b5
Signed-off-by: David Collins <collinsd@codeaurora.org>
(cherry picked from commit 5aabfd7b4159b4235ef924ccd18aea4fced118da)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Enabling RTB(Register Trace Buffer) will help in taking RTB logs. RTB
implements uncached logging of particular events (like readl/writel,
printk, hotplug etc). RTB is useful because it provides a
rough indication of the last events that occured on each core prior to
a crash/reset.
Change-Id: I7b26e2c2b8d012028beaa3d1ed36f85603ad411f
Signed-off-by: Utsab Bose <ubose@codeaurora.org>
(cherry picked from commit 9a341175190201c02062d789a79aa789cb7544d9)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Set the nominal clock rate to 325MHz for the GPU on 8960PRO.
Signed-off-by: Carter Cooper <ccooper@codeaurora.org>
(cherry picked from commit 9be5c4d299eef89b2a4a56c40c09dae96ba79318)
Conflicts:
arch/arm/mach-msm/board-8960.c
Change-Id: I034bb3975de869c7957441f788167382a544a3f0
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Due to availability of Switch on SGLTE Platform to route Modem
or 8960 HSUSB signals on same port, few compliance test like device
mode eye diagram test and EL_27 are failing. Hence it is required to
have different HSUSB PHY setting than 8960. Add HSUSB PHY setting
recommended for SGLTE Platform which is fixing above mentioned
compliance failure.
CRs-Fixed: 385128
CRs-Fixed: 385133
Change-Id: I8b2a56db337af1c3a3ef87a71097c136a19f30da
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
(cherry picked from commit a61da7a6df9c0d477625e3736a4b2c9b18215f8f)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
On 8064 LiQUID with mXT1386E touch controller, the first MOVE event
following the PRESS event arrives with a latency that contributes to
lag in UI. Adjust the move filter to improve the latency.
Also reduce the idle scan interval to have better performance
during idle to active transition.
Change-Id: Iaab93c9b74c736a8dd3b5a66a77d9f6fffce2e4e
Signed-off-by: Jing Lin <jinglin@codeaurora.org>
(cherry picked from commit c6a55cfcb253dc218e2be3317185628211a69660)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>
Target freeze is observed when AR600x wlan driver is loaded
on 7x27a FFA platform which has WCN chipset in it.
msm_AR600X_setup_power() func already takes care of disabling
regulator setting in gpio request (WLAN_DEEP_SLEEP_N) failure
cases. msm_AR600X_shutdown_power() func should NOT try to disable
any regulator related setting when there is gpio request
failures. Doing that in msm_AR600X_shutdown_power() will
lead to the target freeze.
This patch modifies msm_AR600X_shutdown_power() not to perform
any regulator setting in case of gpio request failures.
Change-Id: Iec4737d7c1479fba9d644cc01e38ff3c1ffa02b2
Signed-off-by: Ming-yi Lin <mylin@codeaurora.org>
(cherry picked from commit 920f220b3dbc6898df6781f4f812a2556169906d)
Signed-off-by: Sudhir Sharma <sudsha@codeaurora.org>