batman-adv: use seq_puts instead of seq_printf when the format is constant
As reported by checkpatch, seq_puts has to be preferred with respect to seq_printf when the format is a constant string (no va_args) Signed-off-by: Antonio Quartulli <ordex@autistici.org> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
This commit is contained in:
parent
9cb812c54e
commit
0c81465357
|
@ -500,7 +500,7 @@ int batadv_gw_client_seq_print_text(struct seq_file *seq, void *offset)
|
||||||
rcu_read_unlock();
|
rcu_read_unlock();
|
||||||
|
|
||||||
if (gw_count == 0)
|
if (gw_count == 0)
|
||||||
seq_printf(seq, "No gateways in range ...\n");
|
seq_puts(seq, "No gateways in range ...\n");
|
||||||
|
|
||||||
out:
|
out:
|
||||||
if (primary_if)
|
if (primary_if)
|
||||||
|
|
|
@ -419,7 +419,7 @@ int batadv_algo_seq_print_text(struct seq_file *seq, void *offset)
|
||||||
{
|
{
|
||||||
struct batadv_algo_ops *bat_algo_ops;
|
struct batadv_algo_ops *bat_algo_ops;
|
||||||
|
|
||||||
seq_printf(seq, "Available routing algorithms:\n");
|
seq_puts(seq, "Available routing algorithms:\n");
|
||||||
|
|
||||||
hlist_for_each_entry(bat_algo_ops, &batadv_algo_list, list) {
|
hlist_for_each_entry(bat_algo_ops, &batadv_algo_list, list) {
|
||||||
seq_printf(seq, "%s\n", bat_algo_ops->name);
|
seq_printf(seq, "%s\n", bat_algo_ops->name);
|
||||||
|
|
|
@ -1760,23 +1760,23 @@ int batadv_nc_nodes_seq_print_text(struct seq_file *seq, void *offset)
|
||||||
hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
|
hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
|
||||||
seq_printf(seq, "Node: %pM\n", orig_node->orig);
|
seq_printf(seq, "Node: %pM\n", orig_node->orig);
|
||||||
|
|
||||||
seq_printf(seq, " Ingoing: ");
|
seq_puts(seq, " Ingoing: ");
|
||||||
/* For each in_nc_node to this orig_node */
|
/* For each in_nc_node to this orig_node */
|
||||||
list_for_each_entry_rcu(nc_node,
|
list_for_each_entry_rcu(nc_node,
|
||||||
&orig_node->in_coding_list,
|
&orig_node->in_coding_list,
|
||||||
list)
|
list)
|
||||||
seq_printf(seq, "%pM ",
|
seq_printf(seq, "%pM ",
|
||||||
nc_node->addr);
|
nc_node->addr);
|
||||||
seq_printf(seq, "\n");
|
seq_puts(seq, "\n");
|
||||||
|
|
||||||
seq_printf(seq, " Outgoing: ");
|
seq_puts(seq, " Outgoing: ");
|
||||||
/* For out_nc_node to this orig_node */
|
/* For out_nc_node to this orig_node */
|
||||||
list_for_each_entry_rcu(nc_node,
|
list_for_each_entry_rcu(nc_node,
|
||||||
&orig_node->out_coding_list,
|
&orig_node->out_coding_list,
|
||||||
list)
|
list)
|
||||||
seq_printf(seq, "%pM ",
|
seq_printf(seq, "%pM ",
|
||||||
nc_node->addr);
|
nc_node->addr);
|
||||||
seq_printf(seq, "\n\n");
|
seq_puts(seq, "\n\n");
|
||||||
}
|
}
|
||||||
rcu_read_unlock();
|
rcu_read_unlock();
|
||||||
}
|
}
|
||||||
|
|
|
@ -465,7 +465,7 @@ int batadv_orig_seq_print_text(struct seq_file *seq, void *offset)
|
||||||
neigh_node_tmp->tq_avg);
|
neigh_node_tmp->tq_avg);
|
||||||
}
|
}
|
||||||
|
|
||||||
seq_printf(seq, "\n");
|
seq_puts(seq, "\n");
|
||||||
batman_count++;
|
batman_count++;
|
||||||
|
|
||||||
next:
|
next:
|
||||||
|
@ -475,7 +475,7 @@ next:
|
||||||
}
|
}
|
||||||
|
|
||||||
if (batman_count == 0)
|
if (batman_count == 0)
|
||||||
seq_printf(seq, "No batman nodes in range ...\n");
|
seq_puts(seq, "No batman nodes in range ...\n");
|
||||||
|
|
||||||
out:
|
out:
|
||||||
if (primary_if)
|
if (primary_if)
|
||||||
|
|
|
@ -149,7 +149,7 @@ static void batadv_vis_data_read_prim_sec(struct seq_file *seq,
|
||||||
|
|
||||||
hlist_for_each_entry(entry, if_list, list) {
|
hlist_for_each_entry(entry, if_list, list) {
|
||||||
if (entry->primary)
|
if (entry->primary)
|
||||||
seq_printf(seq, "PRIMARY, ");
|
seq_puts(seq, "PRIMARY, ");
|
||||||
else
|
else
|
||||||
seq_printf(seq, "SEC %pM, ", entry->addr);
|
seq_printf(seq, "SEC %pM, ", entry->addr);
|
||||||
}
|
}
|
||||||
|
@ -207,7 +207,7 @@ static void batadv_vis_data_read_entries(struct seq_file *seq,
|
||||||
if (batadv_compare_eth(entry->addr, packet->vis_orig))
|
if (batadv_compare_eth(entry->addr, packet->vis_orig))
|
||||||
batadv_vis_data_read_prim_sec(seq, list);
|
batadv_vis_data_read_prim_sec(seq, list);
|
||||||
|
|
||||||
seq_printf(seq, "\n");
|
seq_puts(seq, "\n");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue