blkcg: fix gendisk reference leak in blkg_conf_prep()
commit 5f6c2d2b7dbb541c1e922538c49fa04c494ae3d7 upstream. When a blkcg configuration is targeted to a partition rather than a whole device, blkg_conf_prep fails with -EINVAL; unfortunately, it forgets to put the gendisk ref in that case. Fix it. Signed-off-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jens Axboe <axboe@fb.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
15d6dd8f74
commit
74f412afcf
|
@ -720,8 +720,12 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
|
||||||
disk = get_gendisk(MKDEV(major, minor), &part);
|
disk = get_gendisk(MKDEV(major, minor), &part);
|
||||||
if (!disk || part)
|
if (!disk)
|
||||||
return -EINVAL;
|
return -EINVAL;
|
||||||
|
if (part) {
|
||||||
|
put_disk(disk);
|
||||||
|
return -EINVAL;
|
||||||
|
}
|
||||||
|
|
||||||
rcu_read_lock();
|
rcu_read_lock();
|
||||||
spin_lock_irq(disk->queue->queue_lock);
|
spin_lock_irq(disk->queue->queue_lock);
|
||||||
|
|
Loading…
Reference in New Issue