mirror of
https://github.com/followmsi/android_kernel_google_msm.git
synced 2024-11-06 23:17:41 +00:00
Revert "checkpatch: Add warning for blank lines in header"
This reverts commit 8212698c653945d0fd0783829822917bf13a5aab. The original commit incorrectly prevents the following: - Commit messages which cite other commit messages, which are commonly used for attribution; - Any use of checkpatch which doesn't contain a full mail header, such as 'show <ref> | checkpatch.pl -' Change-Id: I681a97913432d05bf66290cf74972aaa4e03fe5d Signed-off-by: Gregory Bean <gbean@codeaurora.org> (cherry picked from commit c73e32b4a1a59e3a33e9c8975ab08b5475d30f3e)
This commit is contained in:
parent
dc4e47c544
commit
45da08a85b
1 changed files with 0 additions and 9 deletions
|
@ -1381,7 +1381,6 @@ sub process {
|
|||
my $stashrawline="";
|
||||
my $subjectline="";
|
||||
my $sublinenr="";
|
||||
my $blankline_flag=0;
|
||||
|
||||
my $length;
|
||||
my $indent;
|
||||
|
@ -1718,7 +1717,6 @@ sub process {
|
|||
if ($line =~ /^\s*signed-off-by:.*(quicinc|qualcomm)\.com/i) {
|
||||
WARN("invalid Signed-off-by identity\n" . $line );
|
||||
}
|
||||
$blankline_flag = 1;
|
||||
}
|
||||
|
||||
#check the patch for invalid author credentials
|
||||
|
@ -1726,13 +1724,6 @@ sub process {
|
|||
WARN("invalid author identity\n" . $line );
|
||||
}
|
||||
|
||||
#check the patch for blank lines in the header
|
||||
if($line =~ /^\s*$/ && $blankline_flag == 1) {
|
||||
WARN("Blank lines should not appear in the header once signed off\n");
|
||||
} elsif($line =~ /^---$/) {
|
||||
$blankline_flag = 0;
|
||||
}
|
||||
|
||||
# Check for wrappage within a valid hunk of the file
|
||||
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
|
||||
ERROR("CORRUPTED_PATCH",
|
||||
|
|
Loading…
Reference in a new issue